Stop publishing First/Last as constructors and use auto-scoping for take and drop.
#10467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove First and Last from exports.
Update libraries for `First` and `Last`. Update `Text_Sub_Range` to use auto-scoping.
jdunkerley
requested review from
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
4e6,
JaroslavTulach and
hubertp
as code owners
JaroslavTulach
approved these changes
Jul 8, 2024
| @@ -789,15 +789,15 @@ type DB_Table | |||
| > Example | |||
| Drop first 10 rows of the table. | |||
|
|
|||
| table.drop (First 10) | |||
| table.drop (..First 10) | |||
There was a problem hiding this comment.
Given the autoscoped constructors are now used in production code, we should find some time to invest into measuring and improving their peak performance.
| @@ -1,4 +1,4 @@ | |||
| from Standard.Base import all hiding First, Last | |||
There was a problem hiding this comment.
Being able to remove hidding is a step forward.
radeusgd
approved these changes
Jul 8, 2024
AdRiley
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
FirstandLastfrom theStandard.Baseexports.Index_Sub_RangeandText_Sub_Range.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.